Avoid false error on is_subclass_of #4472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
isSubClass
branch
from
a26609c to
31a5ad8
Compare
VincentLanglet
force-pushed
the
isSubClass
branch
from
31a5ad8 to
f2663f1
Compare
VincentLanglet
force-pushed
the
isSubClass
branch
from
5500473 to
8576d53
Compare
VincentLanglet
commented
Oct 24, 2025
|
This pull request has been marked as ready for review. |
VincentLanglet
commented
Oct 24, 2025
|
This issue was more complicated than expected... I'm not against your opinion/review @staabm :) |
staabm
reviewed
Oct 29, 2025
staabm
reviewed
Oct 30, 2025
| namespace IsSubclassOf; | ||
|
|
||
| function (Bar $a, Bar $b, Bar $c, Bar $d) { | ||
| if (is_subclass_of($a, Bar::class)) { |
There was a problem hiding this comment.
do we have a test somewhere for use of is_subclass_of with a final-class ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13713
Solves phpstan/phpstan#6305 (comment)
Partially revert #1044 cc @herndlm
I don't think we can resolve the original request of phpstan/phpstan#6305 (comment) without introducing lot of false positive, like shown by this PR.